Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pf6 #2176

Merged
merged 6 commits into from
Mar 5, 2025
Merged

Pf6 #2176

merged 6 commits into from
Mar 5, 2025

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Feb 27, 2025

Merges the PF6 branch back into master for stable release

@florkbr florkbr marked this pull request as ready for review March 5, 2025 20:30
@florkbr
Copy link
Collaborator

florkbr commented Mar 5, 2025

Note: I have updated the commit message for bb48cda to include a ! after the type/scope to indicate this is a breaking/major change. I will test locally with a dry-run that this has the intended effect.

@florkbr
Copy link
Collaborator

florkbr commented Mar 5, 2025

Verified locally with a publish dry-run that this should have the correct effect after merge (and release the stable major version of each package effected by PF6 migration:

➜  frontend-components git:(pf6) ✗ npx nx affected --base=last-release --parallel=1 --baseBranch=master --target=version --trackDeps --postTargets=build,deploy,github --exclude=@redhat-cloud-services/executors,demo --dryRun --verbose

 NX   Running target version for 14 projects:

- @redhat-cloud-services/frontend-components-advisor-components
- @redhat-cloud-services/chrome
- @redhat-cloud-services/frontend-components
- @redhat-cloud-services/rule-components
- @redhat-cloud-services/frontend-components-notifications
- @redhat-cloud-services/frontend-components-remediations
- @redhat-cloud-services/frontend-components-config-utilities
- @redhat-cloud-services/frontend-components-config
- @redhat-cloud-services/eslint-config-redhat-cloud-services
- @redhat-cloud-services/frontend-components-testing
- @redhat-cloud-services/frontend-components-translations
- @redhat-cloud-services/tsc-transform-imports
- @redhat-cloud-services/types
- @redhat-cloud-services/frontend-components-utilities

With additional flags:
  --baseBranch=master
  --trackDeps=true
  --postTargets=build,deploy,github
  --dryRun=true

——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

> nx run @redhat-cloud-services/types:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/types] 🆕 Calculated new version "1.0.24".

---
## [1.0.24](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/types-1.0.23...@redhat-cloud-services/types-1.0.24) (2025-03-05)


### Bug Fixes

* **types:** add drawer actions to chrome API ([ffa5183](https://github.com/RedHatInsights/frontend-components/commit/ffa5183c09a88f303b70c343cc90ccab9c1874f2))
---

[@redhat-cloud-services/types] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/frontend-components-utilities:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-utilities] 🆕 Calculated new version "6.0.0".

---
## [6.0.0](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/frontend-components-utilities-5.0.13...@redhat-cloud-services/frontend-components-utilities-6.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* **deps:** upgrade PatternFly to v6

### Features

* **deps:** upgrade PatternFly to v6 ([bb48cda](https://github.com/RedHatInsights/frontend-components/commit/bb48cdabd98f05bd8bcd0e330ef27025a50b5274))
---

[@redhat-cloud-services/frontend-components-utilities] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/frontend-components:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components] 🆕 Calculated new version "6.0.0".

---
## [6.0.0](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/frontend-components-5.2.12...@redhat-cloud-services/frontend-components-6.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* **deps:** upgrade PatternFly to v6

### Features

* **deps:** upgrade PatternFly to v6 ([bb48cda](https://github.com/RedHatInsights/frontend-components/commit/bb48cdabd98f05bd8bcd0e330ef27025a50b5274))


### Bug Fixes

* using new modal component ([1489612](https://github.com/RedHatInsights/frontend-components/commit/1489612a0a0986b517dd0647fc72f084fbdc00ac))
---

[@redhat-cloud-services/frontend-components] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/frontend-components-config-utilities:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-config-utilities] 🟢 Nothing changed since last release.

> nx run @redhat-cloud-services/tsc-transform-imports:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/tsc-transform-imports] 🟢 Nothing changed since last release.

> nx run @redhat-cloud-services/frontend-components-config:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-config] 🟢 Nothing changed since last release.

> nx run @redhat-cloud-services/frontend-components-notifications:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-notifications] 🆕 Calculated new version "5.0.0".

---
## [5.0.0](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/frontend-components-notifications-4.1.23...@redhat-cloud-services/frontend-components-notifications-5.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* **deps:** upgrade PatternFly to v6

### Features

* **deps:** upgrade PatternFly to v6 ([bb48cda](https://github.com/RedHatInsights/frontend-components/commit/bb48cdabd98f05bd8bcd0e330ef27025a50b5274))
---

[@redhat-cloud-services/frontend-components-notifications] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/eslint-config-redhat-cloud-services:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/eslint-config-redhat-cloud-services] 🟢 Nothing changed since last release.

> nx run @redhat-cloud-services/frontend-components-advisor-components:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-advisor-components] 🆕 Calculated new version "3.0.0".

---
## [3.0.0](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/frontend-components-advisor-components-2.0.22...@redhat-cloud-services/frontend-components-advisor-components-3.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* **deps:** upgrade PatternFly to v6

### Features

* **deps:** upgrade PatternFly to v6 ([bb48cda](https://github.com/RedHatInsights/frontend-components/commit/bb48cdabd98f05bd8bcd0e330ef27025a50b5274))
---

[@redhat-cloud-services/frontend-components-advisor-components] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/chrome:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/chrome] 🆕 Calculated new version "1.0.21".

---
## [1.0.21](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/chrome-1.0.20...@redhat-cloud-services/chrome-1.0.21) (2025-03-05)
---

[@redhat-cloud-services/chrome] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/frontend-components-testing:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-testing] 🟢 Nothing changed since last release.

> nx run @redhat-cloud-services/frontend-components-translations:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-translations] 🆕 Calculated new version "3.2.22".

---
## [3.2.22](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/frontend-components-translations-3.2.21...@redhat-cloud-services/frontend-components-translations-3.2.22) (2025-03-05)
---

[@redhat-cloud-services/frontend-components-translations] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/rule-components:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/rule-components] 🆕 Calculated new version "4.0.0".

---
## [4.0.0](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/rule-components-3.2.31...@redhat-cloud-services/rule-components-4.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* **deps:** upgrade PatternFly to v6

### Features

* **deps:** upgrade PatternFly to v6 ([bb48cda](https://github.com/RedHatInsights/frontend-components/commit/bb48cdabd98f05bd8bcd0e330ef27025a50b5274))
---

[@redhat-cloud-services/rule-components] 📜 Generated CHANGELOG.md.

> nx run @redhat-cloud-services/frontend-components-remediations:version --baseBranch=master --trackDeps --postTargets=build,deploy,github --dryRun

[@redhat-cloud-services/frontend-components-remediations] 🆕 Calculated new version "4.0.0".

---
## [4.0.0](https://github.com/RedHatInsights/frontend-components/compare/@redhat-cloud-services/frontend-components-remediations-3.2.34...@redhat-cloud-services/frontend-components-remediations-4.0.0) (2025-03-05)


### ⚠ BREAKING CHANGES

* **deps:** upgrade PatternFly to v6

### Features

* **deps:** upgrade PatternFly to v6 ([bb48cda](https://github.com/RedHatInsights/frontend-components/commit/bb48cdabd98f05bd8bcd0e330ef27025a50b5274))
---

[@redhat-cloud-services/frontend-components-remediations] 📜 Generated CHANGELOG.md.

——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 NX   Successfully ran target version for 14 projects

@florkbr
Copy link
Collaborator

florkbr commented Mar 5, 2025

I did notice that it appears another patch version will be published for some packages that we merged changes in for in both master and PF6 (the notifications drawer API). This will add a duplicated line to our changelog. The alternative would be to remove those commits entirely - but the rebase is complex as it is.

Edit I was incorrect - these packages needed to be published as a major version. See follow up PR.

Copy link
Member

@tahmidefaz tahmidefaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very familiar with this repo. From what I have seen, I think the changes looks good to me.

@florkbr florkbr merged commit 0a773c7 into master Mar 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants